[Commit-model M4] Implement stage commit (D1 + D5) #103

New issue

david · 2026-08-01T02:22:24Z

david commented

2026-08-01 02:22:24 +00:00

Commit implement output as commit #1; empty ⇒ hard failure (D1 + D5).

Changes

src/implement/services/runImplementStage.ts: after the agent session, captureDiffAgainstBase(runGit, repoRoot, base) → implementation.diff; if !hasStagedOrUncommittedChanges ⇒ throw hard failure (agent did no work) → orchestrator writes error.json and aborts; else git add -- . ':(exclude).pi-loop' then git commit with buildStageCommitMessage(key, summary, 1).

Tests: non-empty ⇒ diff written, add+commit with Pi-Loop-Stage: 1; empty ⇒ hard failure, no commit, error.json path exercised.

Exit: implement always leaves exactly one stage-1 commit or fails fast.

Plan: docs/implementation-plan-commit-model.md §M4. Design: docs/design-commit-model.md.

Commit implement output as commit #1; empty ⇒ hard failure (D1 + D5). **Changes** - `src/implement/services/runImplementStage.ts`: after the agent session, `captureDiffAgainstBase(runGit, repoRoot, base)` → `implementation.diff`; if `!hasStagedOrUncommittedChanges` ⇒ throw hard failure (agent did no work) → orchestrator writes `error.json` and aborts; else `git add -- . ':(exclude).pi-loop'` then `git commit` with `buildStageCommitMessage(key, summary, 1)`. **Tests**: non-empty ⇒ diff written, add+commit with `Pi-Loop-Stage: 1`; empty ⇒ hard failure, no commit, `error.json` path exercised. **Exit**: implement always leaves exactly one stage-1 commit or fails fast. Plan: `docs/implementation-plan-commit-model.md` §M4. Design: `docs/design-commit-model.md`.

david added the

enhancement

pi-loop

labels

2026-08-01 02:22:39 +00:00

david referenced this issue

2026-08-01 05:40:05 +00:00

103: [Commit-model M4] Implement stage commit (D1 + D5) #117

david closed this issue

2026-08-01 05:40:07 +00:00

david commented

2026-08-01 05:40:08 +00:00