Switch Forgejo MR creation from CLI to REST API #21

New issue

david · 2026-07-25T21:46:17Z

david commented

2026-07-25 21:46:17 +00:00

Summary

Switch Forgejo MR/PR creation from CLI (fj) to REST API calls, following the existing issue-fetching pattern.

Motivation

Remove the fj CLI dependency for Forgejo-origin repos.
Make MR creation deterministic, unit-testable code.
Align with how issue fetching already works (REST via ForgejoIssueClient).

Acceptance Criteria

New ForgejoMrClient class in src/forgejo/services/forgejoMrClient.ts
Implements MrClient interface with createMr(input): Promise<CreateMrResult>
Uses POST /api/v1/repos/{owner}/{repo}/pulls endpoint
Reuses existing HttpFetch/withRetry infrastructure
Git operations (branch, commit, push) handled deterministically via gitRunner
runMrStage updated to use ForgejoMrClient for forgejo platform
Unit tests for ForgejoMrClient (success, 401, 403, 404, 429, 500, malformed response)
mr-result.json schema unchanged
No remaining references to fj CLI in the Forgejo code path

Implementation Steps

Create ForgejoMrClient class mirroring ForgejoIssueClient
Update runMrStage to use deterministic git + REST for Forgejo
Remove Forgejo CLI guidance from defaultMrSkillBody
Add unit tests
Verify npm test and npm run lint pass

Design doc: docs/design-rest-mr-creation.md
Implementation plan: docs/implementation-plan-rest-mr.md (Milestone M1)

## Summary Switch Forgejo MR/PR creation from CLI (`fj`) to REST API calls, following the existing issue-fetching pattern. ## Motivation - Remove the `fj` CLI dependency for Forgejo-origin repos. - Make MR creation deterministic, unit-testable code. - Align with how issue fetching already works (REST via `ForgejoIssueClient`). ## Acceptance Criteria - [ ] New `ForgejoMrClient` class in `src/forgejo/services/forgejoMrClient.ts` - [ ] Implements `MrClient` interface with `createMr(input): Promise<CreateMrResult>` - [ ] Uses `POST /api/v1/repos/{owner}/{repo}/pulls` endpoint - [ ] Reuses existing `HttpFetch`/`withRetry` infrastructure - [ ] Git operations (branch, commit, push) handled deterministically via `gitRunner` - [ ] `runMrStage` updated to use `ForgejoMrClient` for `forgejo` platform - [ ] Unit tests for `ForgejoMrClient` (success, 401, 403, 404, 429, 500, malformed response) - [ ] `mr-result.json` schema unchanged - [ ] No remaining references to `fj` CLI in the Forgejo code path ## Implementation Steps 1. Create `ForgejoMrClient` class mirroring `ForgejoIssueClient` 2. Update `runMrStage` to use deterministic git + REST for Forgejo 3. Remove Forgejo CLI guidance from `defaultMrSkillBody` 4. Add unit tests 5. Verify `npm test` and `npm run lint` pass ## Related - Design doc: `docs/design-rest-mr-creation.md` - Implementation plan: `docs/implementation-plan-rest-mr.md` (Milestone M1)

david referenced this issue

2026-07-25 21:46:34 +00:00

Switch GitHub PR creation from CLI to REST API #22

david referenced this issue

2026-07-25 21:46:50 +00:00

Switch GitLab MR creation from CLI to REST API #23

david referenced this issue from a commit

2026-07-25 23:23:19 +00:00

feat(issue-21): Forgejo MR creation via REST API

david referenced this issue from a pull request that will close it,

2026-07-25 23:23:45 +00:00

Switch Forgejo MR creation from CLI to REST API #24