issue-249: add claude-sonnet-5/claude-opus-5 to Vertex catalog + document adding new Vertex models #250
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/issue-249/add-claude-sonnet-5-opus-5-vertex-models-doc"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What & why
Anthropic's Claude Sonnet 5 and Claude Opus 5 are available on Google Cloud
Vertex AI (
claude-sonnet-5/claude-opus-5, no date suffix), but pi-loop'svendored
VERTEX_MODELScatalog was frozen atpi-provider-vertex-anthropic@0.1.3and didn't include them — so
PILOOP_MODEL=vertex-anthropic/claude-sonnet-5(or
--model vertex-anthropic/claude-sonnet-5) failed to resolve.This PR adds both models to the catalog, records the hand-maintained deviation
from upstream, adds regression tests, and documents (in README.md) the process
for adding future Vertex models to the catalog, since it's a manual/hardcoded
list rather than a live lookup.
Per-file breakdown
Modified
src/model/vertexAnthropic/models.ts— addsclaude-opus-5andclaude-sonnet-5entries toVERTEX_MODELS(reasoning-capable, 1M-tokencontext window, 128k max output tokens, matching Anthropic's published
Vertex AI catalog); adds a provenance comment noting the deviation from
vendored upstream
0.1.3.NOTICE— adds a "Model catalog deviation" note explaining thatclaude-sonnet-5/claude-opus-5are hand-added ahead of upstream pickingthem up, with a reminder to reconcile once upstream ships them.
src/model/vertexAnthropic/registerVertexAnthropic.test.ts— adds aVERTEX_MODELS catalogdescribe block asserting both new ids are presentwith the expected
reasoning/contextWindow/maxTokens, and that they'reincluded in the registered provider config.
README.md— adds a "⚠️ Adding a new Vertex model (important)" subsectionunder "Claude on Vertex (optional)" documenting that
VERTEX_MODELSis ahardcoded/vendored snapshot (not a live catalog lookup), and the steps to
add a new model id (edit
models.ts, updateNOTICE, add test coverage,verify with
npm test/npm run lint+ a live run).Added
CHANGELOG.md— new file; "Unreleased / Fixed" entry documenting theclaude-sonnet-5/claude-opus-5catalog gap and fix.Testing
npm run lint— passesnpx vitest run src/model/vertexAnthropic/registerVertexAnthropic.test.ts— 10/10 passingCloses #249