Fix .gitignore pattern mismatch in removePiLoopFromGitignore #46

New issue

david · 2026-07-30T00:35:13Z

david commented

2026-07-30 00:35:13 +00:00

Problem

When a user's .gitignore contains .pi-loop (without trailing slash), removePiLoopFromGitignore() fails to remove it because it only matches .pi-loop/ (with trailing slash). This causes git add -- . :(exclude).pi-loop in the MR stage to fail:

git add -- . :(exclude).pi-loop
The following paths are ignored by one of your .gitignore files:
.pi-loop

Root Cause

src/run/services/gitExclude.ts — removePiLoopFromGitignore() uses exact match against EXCLUDE_ENTRY = '.pi-loop/':

const filtered = lines.filter((line) => line.trim() !== EXCLUDE_ENTRY);

.pi-loop ≠ .pi-loop/ → line stays in .gitignore → git add fails.

Fix

Broaden removePiLoopFromGitignore() to match three patterns:

.pi-loop (no slash)
.pi-loop/ (trailing slash — already handled)
/.pi-loop (root-anchored)

Acceptance Criteria

removePiLoopFromGitignore() removes lines matching .pi-loop, .pi-loop/, or /.pi-loop
Lines with .pi-loop as a substring (e.g. .pi-loop-extra/) are NOT removed
New tests added for .pi-loop (no slash) and /.pi-loop (root-anchored) removal
Existing substring-safety test updated to reference all three patterns
npm run lint and npm test pass

Files to Change

src/run/services/gitExclude.ts — broaden pattern matching
src/run/services/gitExclude.test.ts — add two new tests, update substring safety test

## Problem When a user's `.gitignore` contains `.pi-loop` (without trailing slash), `removePiLoopFromGitignore()` fails to remove it because it only matches `.pi-loop/` (with trailing slash). This causes `git add -- . :(exclude).pi-loop` in the MR stage to fail: ``` git add -- . :(exclude).pi-loop The following paths are ignored by one of your .gitignore files: .pi-loop ``` ## Root Cause `src/run/services/gitExclude.ts` — `removePiLoopFromGitignore()` uses exact match against `EXCLUDE_ENTRY = '.pi-loop/'`: ```typescript const filtered = lines.filter((line) => line.trim() !== EXCLUDE_ENTRY); ``` `.pi-loop` ≠ `.pi-loop/` → line stays in `.gitignore` → `git add` fails. ## Fix Broaden `removePiLoopFromGitignore()` to match three patterns: - `.pi-loop` (no slash) - `.pi-loop/` (trailing slash — already handled) - `/.pi-loop` (root-anchored) ## Acceptance Criteria - [ ] `removePiLoopFromGitignore()` removes lines matching `.pi-loop`, `.pi-loop/`, or `/.pi-loop` - [ ] Lines with `.pi-loop` as a substring (e.g. `.pi-loop-extra/`) are NOT removed - [ ] New tests added for `.pi-loop` (no slash) and `/.pi-loop` (root-anchored) removal - [ ] Existing substring-safety test updated to reference all three patterns - [ ] `npm run lint` and `npm test` pass ## Files to Change - `src/run/services/gitExclude.ts` — broaden pattern matching - `src/run/services/gitExclude.test.ts` — add two new tests, update substring safety test

david added the

bug

resume

labels

2026-07-30 00:35:13 +00:00

david referenced this issue from a commit

2026-07-30 00:37:42 +00:00

fix: broaden .gitignore pattern matching in removePiLoopFromGitignore

david commented

2026-07-30 00:37:55 +00:00

Fixed in #47.

Fixed in [#47](https://git.excelera.net/david/pi-loop/pulls/47).