david/pi-loop
Watch
1
0
Fork
You've already forked pi-loop
 0
Code Issues 20 Pull requests 1 Projects Releases Packages Wiki Activity Actions

M4 — Stage 2: Review (compose model + fallback) #5

New issue
Closed
opened 2026-07-24 00:53:30 +00:00 by david · 0 comments
david commented 2026-07-24 00:53:30 +00:00
Owner
Copy link

Goal: grounded review producing severity-grouped Markdown findings.

Tasks

  • Compose system prompt from REVIEW_SKILL_PATH via the composer (NOT additionalSkillPaths); missing → default review body + degraded.
  • Gather existing standards docs that exist: AGENTS.md, CLAUDE.md, README.md, DOMAIN.md, CODING_STANDARDS.md (skip missing); pass paths/contents in the wrapper.
  • Review session runs build/test/lint via bash AND static review vs standards + implementation.diff.
  • Emit review-findings.md in the documented structure (Critical/High/Medium/Low; each finding file:line + suggested fix).

Depends on: M3.

Validation: with skill present → findings use the skill; with skill absent → default runs, review recorded in degradedStages, findings still well-formed.

**Goal:** grounded review producing severity-grouped Markdown findings. ### Tasks - [ ] Compose system prompt from `REVIEW_SKILL_PATH` via the composer (NOT `additionalSkillPaths`); missing → default review body + `degraded`. - [ ] Gather existing standards docs that exist: `AGENTS.md`, `CLAUDE.md`, `README.md`, `DOMAIN.md`, `CODING_STANDARDS.md` (skip missing); pass paths/contents in the wrapper. - [ ] Review session runs build/test/lint via bash AND static review vs standards + `implementation.diff`. - [ ] Emit `review-findings.md` in the documented structure (Critical/High/Medium/Low; each finding `file:line` + suggested fix). **Depends on:** M3. **Validation:** with skill present → findings use the skill; with skill absent → default runs, review recorded in `degradedStages`, findings still well-formed.
david closed this issue 2026-07-24 21:15:36 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feature/issue-311/doc-updates-and-validation-for-the-no-code-change
feature/issue-307/surface-the-posted-comment-in-the-run-summary-and
feature/issue-306/post-the-comment-at-runpipeline-s-no-code-change-s
feature/issue-305/postnocodechangecomment-deterministic-post-and-mar
feature/issue-304/no-code-change-comment-json-marker-artifact-module
feature/issue-303/deterministic-no-code-change-comment-body-builder
feature/issue-300/mr-description-closes-keyword-auto-close
feature/issue-246/batch-scan-support-for-gitlab-gitlabissueclient-li
feature/issue-286/docs-stage-fails-every-run-when-docs-scope-is-cove
feature/issue-284/gitlab-auto-merge-fails-glab-mr-merge-uses-nonexis
feature/issue-282/fix-config-precedence-piloop-config-yaml-should-ou
feature/issue-274/gitlab-mr-auto-merge-check-uses-invalid-glab-mr-vi
feature/issue-267/network-level-fetch-failures-produce-opaque-fetch
feature/issue-257/recognize-mr-skipped-json-in-resume-completeness-d
feature/issue-256/wire-mr-skip-outcome-into-runpipeline
feature/issue-255/wire-nothing-to-ship-skip-into-runmrstage
feature/issue-254/add-mr-skipped-json-artifact-type-validator
feature/issue-253/add-git-native-nothing-to-ship-helper
feature/issue-230/friction-docs-design-md-adr-016-implementation-pla
feature/issue-229/friction-aggregate-recompute-at-end-of-run-pi-loop
feature/issue-228/friction-wire-remediate-stage-parse-friction-first
feature/issue-226/friction-foundation-entry-schema-parsefriction-par
feature/issue-223/docs-stage-adr-015-design-doc-updates-agents-desig
feature/issue-222/docs-stage-tests-unit-seams-commit-model-resume-e2
feature/issue-221/docs-stage-stage-module-src-docs-skill-body-docssk
feature/issue-220/docs-stage-mr-description-documentation-section-ru
feature/issue-219/docs-stage-resume-integration-type-unions-plumbing
feature/issue-218/docs-stage-git-add-and-discard-guard-docs-diff-art
feature/issue-217/docs-stage-config-surface-docs-section-no-docs-doc
feature/issue-207/feature-piloop-config-yaml-per-repo-config-file-su
feature/issue-201/console-stage-in-prefix-format-hh-mm-stage-remove
feature/issue-193/m5-renderer-sink-test-updates-docs-and-visual-e2e
feature/issue-192/m4-tty-gated-color-styling-layer-for-console-chann
feature/issue-191/m3-stateful-batch-prefixing-prefix-new-lines-only
feature/issue-190/m2-chunk-aware-eventsink-wiring-in-runstage
feature/issue-189/m1-chunk-model-event-renderer-with-full-thinking-l
feature/issue-23/switch-gitlab-mr-creation-from-cli-to-rest-api
feature/issue-180/feat-add-list-models-cli-flag-to-list-available-pi
feature/issue-175/enforce-pi-loop-in-target-repo-gitignore-at-startu
feature/issue-174/add-per-stage-model-banner-showing-the-resolved-mo
feature/issue-179/docs-adr-updates-for-per-run-model-override
feature/issue-178/effective-model-override-dual-source-preflight-in
feature/issue-177/source-aware-model-error-messages-in-resolvestagem
feature/issue-176/add-model-id-cli-flag-parsing-help-text
feature/issue-172/make-piloop-model-required-fail-fast-model-pinning
feature/issue-170/enforce-bash-timeouts-for-stage-sessions-default-1
feature/issue-160/m8-update-cli-reporting-for-no-code-change-outcome
feature/issue-159/m7-integrate-no-code-change-into-batch-runner
feature/issue-158/m6-add-no-code-change-outcome-to-batch-manifest
feature/issue-157/m5-add-defensive-skip-in-mr-stage-for-empty-workin
feature/issue-156/m4-handle-no-code-change-in-pipeline-orchestrator
feature/issue-155/m3-add-no-code-change-detection-to-implement-stage
feature/issue-154/m2-update-implement-skill-prompt-with-no-code-chan
feature/issue-153/m1-add-no-code-change-artifact-schema-and-i-o
feature/issue-44/git-worktree-support-for-bare-repos
feature/issue-140/batch-stream-agent-output-with-per-issue-i-n-key-p
feature/issue-139/console-stage-header-separators-from-runpipeline-v
feature/issue-138/logging-switch-logger-timestamps-from-iso-to-hh-mm
feature/issue-134/console-indent-multi-line-tool-result-continuation
feature/issue-132/timing-batch-level-started-completed-total-lines
feature/issue-131/timing-time-to-mr-generated-in-in-pr-description
feature/issue-130/timing-start-finish-total-lines-with-per-attempt-a
feature/issue-129/timing-per-stage-duration-lines-in-runpipeline-fin
feature/issue-128/timing-add-formatduration-humanization-helper
feature/issue-107/commit-model-m8-git-aware-resume-d6-d8
feature/issue-106/commit-model-m7-deterministic-mr-stage-on-all-plat
feature/issue-105/commit-model-m6-remediate-stage-commit-d1-d5
feature/issue-104/commit-model-m5-review-stage-no-commit-audit
feature/issue-103/commit-model-m4-implement-stage-commit-d1-d5
feature/issue-102/commit-model-m3-fetch-branch-creation-d4
feature/issue-101/commit-model-m2-fresh-run-clean-tree-gate-d3
feature/issue-80/auto-merge-m5-orchestrator-wiring-issue-close
feature/issue-76/auto-merge-m1-config-cli-flag-auto-merge-piloop-au
feature/issue-77/auto-merge-m2-issue-close-clients-forgejo-github-g
No results found.
Labels
Clear labels   
batch

   
bug

   
chore
Maintenance tasks, cleanup, housekeeping

  
documentation

   
enhancement

   
pi-loop

   
ready

   
resume
No labels
batch
bug
chore
documentation
enhancement
pi-loop
ready
resume
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
david/pi-loop#5
No description provided.