774e6005a3
Add validation and error handling for removing linked worktrees: - validateRemoveWorktreeInput() — validates path is non-empty - isMainRepository() — refuses removal of main repo root - hasUncommittedChanges() — checks git status --porcelain output - buildWorktreeRemoveCommand() — builds git worktree remove args Wire up createRemoveWorktreeTool with full validation pipeline: 1. Validate input parameters (path) 2. Check if target is the main repo — refuse with prune suggestion 3. Check for uncommitted changes — refuse with stash/commit message 4. Run git worktree remove <path> 5. Surface git errors with helpful suggestions
117 lines
4.3 KiB
TypeScript
117 lines
4.3 KiB
TypeScript
/**
|
|
* Unit tests for git_worktree_remove validation and command-building functions.
|
|
*
|
|
* Tests cover input validation, main repo detection, uncommitted changes check,
|
|
* and command building for `git worktree remove`.
|
|
*/
|
|
|
|
import { describe, it, expect } from "bun:test";
|
|
import {
|
|
validateRemoveWorktreeInput,
|
|
isMainRepository,
|
|
hasUncommittedChanges,
|
|
buildWorktreeRemoveCommand,
|
|
} from "./pi-worktree-remove";
|
|
|
|
// ─── validateRemoveWorktreeInput ──────────────────────────────────────
|
|
|
|
describe("validateRemoveWorktreeInput (Issue #5)", () => {
|
|
it("returns null for valid path", () => {
|
|
const result = validateRemoveWorktreeInput("/tmp/worktrees/feature-x");
|
|
expect(result).toBeNull();
|
|
});
|
|
|
|
it("returns error for empty path", () => {
|
|
const result = validateRemoveWorktreeInput("");
|
|
expect(result).not.toBeNull();
|
|
if (result) expect(result.message).toContain("cannot be empty");
|
|
});
|
|
|
|
it("returns error for whitespace-only path", () => {
|
|
const result = validateRemoveWorktreeInput(" ");
|
|
expect(result).not.toBeNull();
|
|
});
|
|
|
|
it("includes suggestion in error message", () => {
|
|
const result = validateRemoveWorktreeInput("");
|
|
expect(result).not.toBeNull();
|
|
if (result) expect(result.suggestion).toBeDefined();
|
|
});
|
|
});
|
|
|
|
// ─── isMainRepository ────────────────────────────────────────────────
|
|
|
|
describe("isMainRepository (Issue #5)", () => {
|
|
it("returns true when target path matches main repo root", () => {
|
|
const result = isMainRepository("/home/user/project", "/home/user/project");
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
it("returns false when target path differs from main repo root", () => {
|
|
const result = isMainRepository("/tmp/feature-x", "/home/user/project");
|
|
expect(result).toBe(false);
|
|
});
|
|
|
|
it("handles trailing slash differences in paths", () => {
|
|
const result = isMainRepository("/home/user/project/", "/home/user/project");
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
it("returns false for subdirectory of main repo (worktree outside)", () => {
|
|
const result = isMainRepository("../worktrees/feature-x", "/home/user/project");
|
|
expect(result).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ─── hasUncommittedChanges ──────────────────────────────────────────
|
|
|
|
describe("hasUncommittedChanges (Issue #5)", () => {
|
|
it("returns true when git status output has content", () => {
|
|
const result = hasUncommittedChanges(" modified: file.txt\n");
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
it("returns false when git status output is empty", () => {
|
|
const result = hasUncommittedChanges("");
|
|
expect(result).toBe(false);
|
|
});
|
|
|
|
it("returns false when git status output is whitespace only", () => {
|
|
const result = hasUncommittedChanges(" \n ");
|
|
expect(result).toBe(false);
|
|
});
|
|
|
|
it("detects staged changes", () => {
|
|
const result = hasUncommittedChanges("new file: added.txt\n");
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
it("detects untracked files in status output", () => {
|
|
const result = hasUncommittedChanges("?? untracked-file.txt\n");
|
|
expect(result).toBe(true);
|
|
});
|
|
});
|
|
|
|
// ─── buildWorktreeRemoveCommand ──────────────────────────────────────
|
|
|
|
describe("buildWorktreeRemoveCommand (Issue #5)", () => {
|
|
it("returns basic remove command without flags", () => {
|
|
const result = buildWorktreeRemoveCommand("/tmp/worktrees/feature-x");
|
|
expect(result).toEqual(["worktree", "remove", "/tmp/worktrees/feature-x"]);
|
|
});
|
|
|
|
it("includes --force flag when force is true", () => {
|
|
const result = buildWorktreeRemoveCommand("/tmp/worktrees/feature-x", { force: true });
|
|
expect(result).toContain("--force");
|
|
});
|
|
|
|
it("places path as the last argument", () => {
|
|
const result = buildWorktreeRemoveCommand("/tmp/worktrees/feature-x", { force: true });
|
|
expect(result[result.length - 1]).toBe("/tmp/worktrees/feature-x");
|
|
});
|
|
|
|
it("builds correct command with force flag", () => {
|
|
const result = buildWorktreeRemoveCommand("/tmp/worktrees/feature-x", { force: true });
|
|
expect(result).toEqual(["worktree", "remove", "--force", "/tmp/worktrees/feature-x"]);
|
|
});
|
|
});
|