Final verification: milestone/label CRUD full suite green + task_plan.md update #28

New issue

Closed

opened 2026-08-18 02:34:22 +00:00 by david · 0 comments

david commented

2026-08-18 02:34:22 +00:00

Owner

Summary

Run the full verification pass for the milestone CRUD + label-create work (all 8 new tools), and update task_plan.md/progress.md with a new Phase 7 entry, mirroring how Phases 0–6 were documented for the original 23-tool build.

Background

Depends on: #18, #20, #21, #22, #23, #24, #25, #26, #27 (label create, all 7 milestone tools, the promptGuidelines cross-reference, and the README/DESIGN doc updates) — this is the final closing step once everything else is merged.

extensions/forgejo/task_plan.md tracks every implementation task with a TDD Status column (RED/GREEN/REFACTOR checkboxes) and a Done column, structured in numbered phases (0.x through 6.x). progress.md contains narrative summaries per task (e.g. "Task 1.1 src/errors.ts — RED (module missing) → GREEN 3/3. ..."). This issue closes out the milestone/label work by adding equivalent rows/entries for the new Phase 7 tasks, and confirms the whole test suite is green end-to-end after all the individual pieces have landed.

Implementation Details

Run npm test from extensions/forgejo/ — confirm all tests pass, including everything added across the batch (label create, 7 milestone functions, 7 milestone tools + label-create tool registrations, promptGuidelines updates).
Run npm run check — confirm lint/typecheck passes with no errors introduced by any of the batch's changes.

Update task_plan.md: append a new ## Phase 7 section (or extend the existing table) with one row per task actually completed, matching the granularity used for Phase 2 (issues) and Phase 3 (PRs) — e.g.:

| 7.1 | src/issues.ts — createLabel() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.2 | src/milestones.ts — createMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.3 | listMilestones() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.4 | viewMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.5 | editMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.6 | closeMilestone() / reopenMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.7 | deleteMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.8 | src/index.ts — register 8 new tools + formatMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.9 | promptGuidelines cross-reference (issue/PR create → forgejo_list_milestones) | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |
| 7.10 | README.md + docs/DESIGN.md updates | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ |

(Adjust numbering/rows to match what was actually delivered by the time this issue is picked up — check off only tasks genuinely complete and tested.)

Update progress.md: add a narrative entry summarizing Phase 7, in the same style as existing entries (e.g. "Task 7.1 src/issues.ts createLabel() — RED (no function) → GREEN N/N. ..."), covering what was built, key implementation decisions (e.g. thin-wrapper pattern for close/reopen, src/milestones.ts as a new file), and final test counts.
Double-check the tool count claims are consistent everywhere they appear (README.md, docs/DESIGN.md, task_plan.md header comment) — should now read as 31 tools total (23 original + 8 new) if that issue's doc updates already landed; if not, flag the discrepancy rather than silently fixing scope outside this issue.

Acceptance Criteria

npm test passes with zero failures across the entire extensions/forgejo test suite.
npm run check passes with zero errors/warnings introduced by the batch.
task_plan.md has a complete, accurate Phase 7 section reflecting exactly what was implemented (no aspirational/unchecked rows for finished work).
progress.md has a Phase 7 narrative summary consistent with the style of existing entries.
Tool-count references across README.md/docs/DESIGN.md/task_plan.md are internally consistent.
No leftover TODO/stub code or skipped tests related to the milestone/label work.

Test Plan

cd extensions/forgejo && npm test — full suite, zero failures, review coverage output for the new files (src/milestones.ts, tests/milestones.test.ts) to confirm meaningful coverage (not just trivially passing).
npm run check — zero errors.
Manually diff task_plan.md and progress.md against the actual shipped code (src/milestones.ts, src/issues.ts, src/index.ts) to confirm the documentation is truthful, not just present.

## Summary Run the full verification pass for the milestone CRUD + label-create work (all 8 new tools), and update `task_plan.md`/`progress.md` with a new Phase 7 entry, mirroring how Phases 0–6 were documented for the original 23-tool build. ## Background **Depends on:** #18, #20, #21, #22, #23, #24, #25, #26, #27 (label create, all 7 milestone tools, the promptGuidelines cross-reference, and the README/DESIGN doc updates) — this is the final closing step once everything else is merged. `extensions/forgejo/task_plan.md` tracks every implementation task with a `TDD Status` column (`RED`/`GREEN`/`REFACTOR` checkboxes) and a `Done` column, structured in numbered phases (0.x through 6.x). `progress.md` contains narrative summaries per task (e.g. "Task 1.1 src/errors.ts — RED (module missing) → GREEN 3/3. ..."). This issue closes out the milestone/label work by adding equivalent rows/entries for the new Phase 7 tasks, and confirms the whole test suite is green end-to-end after all the individual pieces have landed. ## Implementation Details 1. Run `npm test` from `extensions/forgejo/` — confirm all tests pass, including everything added across the batch (label create, 7 milestone functions, 7 milestone tools + label-create tool registrations, promptGuidelines updates). 2. Run `npm run check` — confirm lint/typecheck passes with no errors introduced by any of the batch's changes. 3. Update `task_plan.md`: append a new `## Phase 7` section (or extend the existing table) with one row per task actually completed, matching the granularity used for Phase 2 (issues) and Phase 3 (PRs) — e.g.: ```markdown | 7.1 | src/issues.ts — createLabel() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.2 | src/milestones.ts — createMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.3 | listMilestones() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.4 | viewMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.5 | editMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.6 | closeMilestone() / reopenMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.7 | deleteMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.8 | src/index.ts — register 8 new tools + formatMilestone() | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.9 | promptGuidelines cross-reference (issue/PR create → forgejo_list_milestones) | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | | 7.10 | README.md + docs/DESIGN.md updates | ☑ RED ☑ GREEN ☑ REFACTOR | ☑ | ``` (Adjust numbering/rows to match what was actually delivered by the time this issue is picked up — check off only tasks genuinely complete and tested.) 4. Update `progress.md`: add a narrative entry summarizing Phase 7, in the same style as existing entries (e.g. "**Task 7.1 src/issues.ts createLabel()** — RED (no function) → GREEN N/N. ..."), covering what was built, key implementation decisions (e.g. thin-wrapper pattern for close/reopen, `src/milestones.ts` as a new file), and final test counts. 5. Double-check the tool count claims are consistent everywhere they appear (`README.md`, `docs/DESIGN.md`, `task_plan.md` header comment) — should now read as 31 tools total (23 original + 8 new) if that issue's doc updates already landed; if not, flag the discrepancy rather than silently fixing scope outside this issue. ## Acceptance Criteria - [ ] `npm test` passes with zero failures across the entire `extensions/forgejo` test suite. - [ ] `npm run check` passes with zero errors/warnings introduced by the batch. - [ ] `task_plan.md` has a complete, accurate Phase 7 section reflecting exactly what was implemented (no aspirational/unchecked rows for finished work). - [ ] `progress.md` has a Phase 7 narrative summary consistent with the style of existing entries. - [ ] Tool-count references across `README.md`/`docs/DESIGN.md`/`task_plan.md` are internally consistent. - [ ] No leftover `TODO`/stub code or skipped tests related to the milestone/label work. ## Test Plan 1. `cd extensions/forgejo && npm test` — full suite, zero failures, review coverage output for the new files (`src/milestones.ts`, `tests/milestones.test.ts`) to confirm meaningful coverage (not just trivially passing). 2. `npm run check` — zero errors. 3. Manually diff `task_plan.md` and `progress.md` against the actual shipped code (`src/milestones.ts`, `src/issues.ts`, `src/index.ts`) to confirm the documentation is truthful, not just present.

david added the

chore

label

2026-08-18 02:34:22 +00:00

david referenced this issue

2026-08-18 02:34:38 +00:00

Extend forgejo extension: milestone create/list + label create tools #13

david referenced this issue from a pull request that will close it,

2026-09-18 02:20:51 +00:00

chore: final verification docs for milestone/label CRUD batch #278

david closed this issue

2026-09-18 03:43:42 +00:00