issue-186: Scaffold the penpot extension directory and register it in the repo manifest #219

Merged

david merged 2 commits from feature/issue-186/scaffold-the-penpot-extension-directory-and-regist into main

2026-09-14 23:26:23 +00:00

david commented

2026-09-14 23:26:22 +00:00

Owner

186: Scaffold the penpot extension directory and register it in the repo manifest

Closes #186 — 186.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 2m 30s.

Review findings

The only finding concerns commit metadata (the subject line of commit b84a211). Remediation runs under an explicit no-commit/no-amend constraint and the pipeline captures only the working-tree diff, so this cannot be fixed here. No code changes were warranted; I verified the working tree is clean and that the single failing npm test (126 pass / 1 fail, the stale extensions/mongodb/index.ts manifest assertion) is pre-existing and unrelated to the penpot scaffold.

Review Findings — 186

Summary

No fixes were applied. The sole finding (Low) concerns the commit subject of b84a211, but the remediation stage is explicitly barred from committing, amending, staging, or branching — and the pipeline captures only the working-tree diff, so commit metadata is not addressable here. All existing changes were left byte-for-byte intact (working tree clean). Gates re-run: npm test → 126 pass / 1 fail, the single failure being the pre-existing scripts/local-install.test.mjs:1875 assertion on the removed extensions/mongodb/index.ts entry, unchanged from before this turn and unrelated to penpot. No build or lint script exists in the root package.json.

Critical

None

High

None

Medium

None

Low

package.json:23 — The accompanying commit b84a211 uses the subject 186: Scaffold the penpot extension directory and register it in the repo manifest, but AGENTS.md mandates issue-<N>: <summary> (e.g. issue-42: add user auth); recent non-pipeline commits follow this (issue-184:, issue-182:). This is commit metadata, not code, and matches the older pipeline pattern (172:, 169:), but it deviates from the documented standard. Suggested fix: amend the commit subject to issue-186: Scaffold the penpot extension directory and register it in the repo manifest before the PR is opened (squash-merge will otherwise propagate the non-conforming title).

Note (not a finding against this change): the two red gates are pre-existing defects unrelated to penpot — scripts/local-install.test.mjs:1875 asserts extensions/mongodb/index.ts is in the manifest after commit 4394492 removed it, and the root node --test also picks up the jest/bun suites under extensions/forgejo, extensions/pr-comments, extensions/mongodb, extensions/victorialogs, and extensions/postgres. None should be attributed to Stage 1, but the repo owner may want to reconcile the stale manifest assertion separately.

Documentation

Updated files:

README.md

## 186: Scaffold the penpot extension directory and register it in the repo manifest Closes #186 — [186](https://git.excelera.net/david/pi-extensions-and-skills/issues/186). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 2m 30s. ## Review findings The only finding concerns commit metadata (the subject line of commit `b84a211`). Remediation runs under an explicit no-commit/no-amend constraint and the pipeline captures only the working-tree diff, so this cannot be fixed here. No code changes were warranted; I verified the working tree is clean and that the single failing `npm test` (126 pass / 1 fail, the stale `extensions/mongodb/index.ts` manifest assertion) is pre-existing and unrelated to the penpot scaffold. # Review Findings — 186 ## Summary No fixes were applied. The sole finding (Low) concerns the *commit subject* of `b84a211`, but the remediation stage is explicitly barred from committing, amending, staging, or branching — and the pipeline captures only the working-tree diff, so commit metadata is not addressable here. All existing changes were left byte-for-byte intact (working tree clean). Gates re-run: `npm test` → 126 pass / 1 fail, the single failure being the pre-existing `scripts/local-install.test.mjs:1875` assertion on the removed `extensions/mongodb/index.ts` entry, unchanged from before this turn and unrelated to penpot. No `build` or `lint` script exists in the root `package.json`. ## Critical - [ ] None ## High - [ ] None ## Medium - [ ] None ## Low - [ ] `package.json:23` — The accompanying commit `b84a211` uses the subject `186: Scaffold the penpot extension directory and register it in the repo manifest`, but AGENTS.md mandates `issue-<N>: <summary>` (e.g. `issue-42: add user auth`); recent non-pipeline commits follow this (`issue-184:`, `issue-182:`). This is commit metadata, not code, and matches the older pipeline pattern (`172:`, `169:`), but it deviates from the documented standard. Suggested fix: amend the commit subject to `issue-186: Scaffold the penpot extension directory and register it in the repo manifest` before the PR is opened (squash-merge will otherwise propagate the non-conforming title). _Note (not a finding against this change): the two red gates are pre-existing defects unrelated to penpot — `scripts/local-install.test.mjs:1875` asserts `extensions/mongodb/index.ts` is in the manifest after commit `4394492` removed it, and the root `node --test` also picks up the jest/bun suites under `extensions/forgejo`, `extensions/pr-comments`, `extensions/mongodb`, `extensions/victorialogs`, and `extensions/postgres`. None should be attributed to Stage 1, but the repo owner may want to reconcile the stale manifest assertion separately._ ## Documentation Updated files: - README.md

david added 2 commits

2026-09-14 23:26:22 +00:00