issue-199: Implement asset-reference resolution plus penpot_add_rect and penpot_add_text #232

Merged

david merged 2 commits from feature/issue-199/implement-asset-reference-resolution-plus-penpot-a into main

2026-09-15 03:30:10 +00:00

david commented

2026-09-15 03:30:09 +00:00

Owner

199: Implement asset-reference resolution plus penpot_add_rect and penpot_add_text

Closes #199 — 199.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 17m 49s.

Review findings

I'll start by exploring the repository to understand the current state.Let me read the relevant files.Now I'll implement the fixes. Starting with shapes.ts (align-self tuple, grow types, resolveStyleArg guard):Now schema.ts — add the layout_item_align_self fragment:Now rect.ts — forward layout_item_align_self:Now text.ts — align-self forwarding, grow type, and the typography/font conflict:Now libraryRefs.ts — refuse a partial typography asset instead of mixing in defaults:Now placement.ts — make the parent hint generic (rect requires parent_id):Now update the tests. First rect.test.ts:Now text.test.ts:Now add shapes.test.ts guard tests and a new libraryRefs.test.ts:Now the CHANGELOG entry:Now the root README.md:Now let me run the penpot test suite:Let me check whether a TypeScript compiler is available to sanity-check types:Let me review the final state of the key changed files:All fixes are in place and the penpot suite is green (331/331). The full npm test remains at 457 pass / 1 fail, the single failure being the pre-existing mongodb manifest assertion that the finding explicitly places out of scope.

## 199: Implement asset-reference resolution plus penpot_add_rect and penpot_add_text Closes #199 — [199](https://git.excelera.net/david/pi-extensions-and-skills/issues/199). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 17m 49s. ## Review findings I'll start by exploring the repository to understand the current state.Let me read the relevant files.Now I'll implement the fixes. Starting with `shapes.ts` (align-self tuple, grow types, `resolveStyleArg` guard):Now `schema.ts` — add the `layout_item_align_self` fragment:Now `rect.ts` — forward `layout_item_align_self`:Now `text.ts` — align-self forwarding, grow type, and the typography/font conflict:Now `libraryRefs.ts` — refuse a partial typography asset instead of mixing in defaults:Now `placement.ts` — make the parent hint generic (rect requires `parent_id`):Now update the tests. First `rect.test.ts`:Now `text.test.ts`:Now add `shapes.test.ts` guard tests and a new `libraryRefs.test.ts`:Now the CHANGELOG entry:Now the root `README.md`:Now let me run the penpot test suite:Let me check whether a TypeScript compiler is available to sanity-check types:Let me review the final state of the key changed files:All fixes are in place and the penpot suite is green (331/331). The full `npm test` remains at 457 pass / 1 fail, the single failure being the pre-existing `mongodb` manifest assertion that the finding explicitly places out of scope.

david added 2 commits

2026-09-15 03:30:09 +00:00