issue-298: Bump the grillme extension to 0.4.0 and add the changelog entry #308

Merged

david merged 2 commits from feature/issue-298/bump-the-grillme-extension-to-0-4-0-and-add-the-ch into main

2026-10-09 22:30:29 +00:00

david commented

2026-10-09 22:30:28 +00:00

Owner

298: Bump the grillme extension to 0.4.0 and add the changelog entry

Closes #298 — 298.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 4m 43s.

Review findings

The critical finding is clear: restore the original #291–#297 bullet and add a separate #298 bullet. Let me apply that programmatically to avoid transcription errors with the unicode/backticks.Critical fix applied and verified verbatim. Now let me discover and run the project gates.# Review Findings — 298

Summary

Fixed the Critical finding: restored the pre-existing #291–#297 ### Changed bullet verbatim (verified byte-for-byte against 3377a20) and added a separate ### Changed bullet for issue #298 that names the two surfaces, the always-on best-effort status, the three exemptions, the licensing approach (paraphrase / credit / link / no dictionary / never "STE compliant"), and the 0.4.0 bump. The file now adds an entry rather than rewriting one, satisfying the issue's "existing headings and entries are untouched" criterion. Gates: root npm test green (1474 pass, 0 fail, 1 skipped) and cd extensions/grillme && npm test green (472 pass, 0 fail). The Low finding is left unresolved: it asks for a commit-message amendment, but this stage is forbidden from committing/staging/pushing, so it can only be handled by the pipeline at commit time (and the review itself notes it is pre-existing drift across #295–#297).

Critical

CHANGELOG.md:58 — the pre-existing #291–#297 ### Changed bullet was rewritten in place (HEAD text at line 58 vs the base text at 3377a20) instead of a new bullet being added for #298. This directly violates the issue's instruction "Do not restructure, rename, or remove any existing changelog heading or entry" and the acceptance criterion "Existing changelog headings and entries are untouched, and the file still reads as Keep a Changelog", and it deletes the earlier entry's recorded detail (e.g. "tool names/parameter names/commands/enums stay byte-identical"). Suggested fix: restore the original #291–#297 bullet verbatim and add a separate ### Changed bullet for this issue that names the two surfaces, the always-on best-effort status, the three exemptions, the licensing approach (paraphrase / credit / link / no dictionary / never "STE compliant") and the 0.4.0 bump, and links (issue #298); only consolidate the two entries if the issue owner amends that acceptance criterion (recorded in the run's friction log as a worked-around, so the criterion was knowingly missed).

High

Medium

Low

AGENTS.md:26 — the Stage 1 commit subject is 298: Bump the grillme extension to 0.4.0 and add the changelog entry, but AGENTS.md requires the issue-<N>: <summary> form for an enhancement issue. Suggested fix: amend the Stage 1 commit message to issue-298: Bump the grillme extension to 0.4.0 and add the changelog entry before the PR is opened (the branch name and the eventual PR title already follow the issue-<N> convention). Note: recent merged commits (#295–#297) use the same bare N: form, so this is pre-existing pipeline drift rather than unique to this change.

## 298: Bump the grillme extension to 0.4.0 and add the changelog entry Closes #298 — [298](https://git.excelera.net/david/pi-extensions-and-skills/issues/298). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 4m 43s. ## Review findings The critical finding is clear: restore the original `#291–#297` bullet and add a separate #298 bullet. Let me apply that programmatically to avoid transcription errors with the unicode/backticks.Critical fix applied and verified verbatim. Now let me discover and run the project gates.# Review Findings — 298 ## Summary Fixed the Critical finding: restored the pre-existing `#291–#297` `### Changed` bullet verbatim (verified byte-for-byte against `3377a20`) and added a separate `### Changed` bullet for issue #298 that names the two surfaces, the always-on best-effort status, the three exemptions, the licensing approach (paraphrase / credit / link / no dictionary / never "STE compliant"), and the `0.4.0` bump. The file now adds an entry rather than rewriting one, satisfying the issue's "existing headings and entries are untouched" criterion. Gates: root `npm test` green (1474 pass, 0 fail, 1 skipped) and `cd extensions/grillme && npm test` green (472 pass, 0 fail). The Low finding is left unresolved: it asks for a commit-message amendment, but this stage is forbidden from committing/staging/pushing, so it can only be handled by the pipeline at commit time (and the review itself notes it is pre-existing drift across #295–#297). ## Critical - [x] CHANGELOG.md:58 — the pre-existing `#291–#297` `### Changed` bullet was rewritten in place (HEAD text at line 58 vs the base text at `3377a20`) instead of a new bullet being added for #298. This directly violates the issue's instruction "Do not restructure, rename, or remove any existing changelog heading or entry" and the acceptance criterion "Existing changelog headings and entries are untouched, and the file still reads as Keep a Changelog", and it deletes the earlier entry's recorded detail (e.g. "tool names/parameter names/commands/enums stay byte-identical"). Suggested fix: restore the original `#291–#297` bullet verbatim and add a separate `### Changed` bullet for this issue that names the two surfaces, the always-on best-effort status, the three exemptions, the licensing approach (paraphrase / credit / link / no dictionary / never "STE compliant") and the `0.4.0` bump, and links `(issue #298)`; only consolidate the two entries if the issue owner amends that acceptance criterion (recorded in the run's friction log as a `worked-around`, so the criterion was knowingly missed). ## High ## Medium ## Low - [ ] AGENTS.md:26 — the Stage 1 commit subject is `298: Bump the grillme extension to 0.4.0 and add the changelog entry`, but AGENTS.md requires the `issue-<N>: <summary>` form for an `enhancement` issue. Suggested fix: amend the Stage 1 commit message to `issue-298: Bump the grillme extension to 0.4.0 and add the changelog entry` before the PR is opened (the branch name and the eventual PR title already follow the `issue-<N>` convention). Note: recent merged commits (#295–#297) use the same bare `N:` form, so this is pre-existing pipeline drift rather than unique to this change.

david added 2 commits

2026-10-09 22:30:28 +00:00