330: MSSQL: register extension, add tests to root test script, add root README entry #354

Merged

david merged 2 commits from feature/issue-330/mssql-register-extension-add-tests-to-root-test-sc into main

2026-11-11 00:44:11 +00:00

david commented

2026-11-11 00:44:09 +00:00

Owner

330: MSSQL: register extension, add tests to root test script, add root README entry

Implements 330.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 2m 52s.

Review findings

Review Findings — 330

Summary

I fixed both Low findings. The README extensions heading now says "Extensions (12)". In scripts/local-install.test.mjs, the direct-invocation test now compares against realpathSync(resolve(cwd)), which resolves the macOS /private/var temp-dir symlink. I re-ran node --test scripts/local-install.test.mjs and all 99 tests passed. I did not re-run the full npm test. I first applied the realpathSync change to two other tests and reverted it there, because they pass without it.

Critical

High

Medium

Low

README.md:27 — The heading says "Extensions (10)", but the table lists 12 rows with mssql added, and it was already stale before this change. Suggested fix: update the count to 12 (or drop the number).
scripts/local-install.test.mjs:1792 — The pre-existing test fails on macOS because it compares a non-realpath temp dir with /private/var/.... It is not caused by this diff, but it leaves npm test red locally. Suggested fix: compare against fs.realpathSync(tmpDir) in a separate change.

## 330: MSSQL: register extension, add tests to root test script, add root README entry Implements [330](https://git.excelera.net/david/pi-extensions-and-skills/issues/330). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 2m 52s. ## Review findings # Review Findings — 330 ## Summary I fixed both Low findings. The README extensions heading now says "Extensions (12)". In `scripts/local-install.test.mjs`, the direct-invocation test now compares against `realpathSync(resolve(cwd))`, which resolves the macOS `/private/var` temp-dir symlink. I re-ran `node --test scripts/local-install.test.mjs` and all 99 tests passed. I did not re-run the full `npm test`. I first applied the `realpathSync` change to two other tests and reverted it there, because they pass without it. ## Critical ## High ## Medium ## Low - [x] README.md:27 — The heading says "Extensions (10)", but the table lists 12 rows with mssql added, and it was already stale before this change. Suggested fix: update the count to 12 (or drop the number). - [x] scripts/local-install.test.mjs:1792 — The pre-existing test fails on macOS because it compares a non-realpath temp dir with `/private/var/...`. It is not caused by this diff, but it leaves `npm test` red locally. Suggested fix: compare against `fs.realpathSync(tmpDir)` in a separate change.

david added 2 commits

2026-11-11 00:44:09 +00:00