26: Cross-reference forgejo_list_milestones from issue/PR create promptGuidelines #40

Merged

david merged 2 commits from feature/issue-26/cross-reference-forgejo-list-milestones-from-issue into main

2026-08-18 08:39:16 +00:00

david commented

2026-08-18 08:39:14 +00:00

Owner

26: Cross-reference forgejo_list_milestones from issue/PR create promptGuidelines

Implements 26.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 2m 47s.

Review findings

The change is committed and the working tree is clean — the Stage 1 diff is already in place. Let me check the existing test conventions before making fixes.Now I'll apply both fixes: add the guideline-content test (Medium) and mirror the labels wording in the guidelines (Low).Both fixes applied. Now let me run the gates (build, check, test) discovered from extensions/forgejo/package.json.All gates pass — 179 tests (up from 178 with the new test). Let me verify the final diff.Both findings are resolved and all gates pass. Here is the final annotated findings document.

Review Findings — 26

Summary

Both findings were fixed in a single pass. Medium: added a generic invariant test in extensions/forgejo/tests/index.test.ts asserting that every tool whose parameters schema exposes a milestone property references forgejo_list_milestones in its promptGuidelines — pinning the added cross-reference and guarding against future regression. Low: reworded the new guideline in both forgejo_issue_create and forgejo_pr_create to "Use forgejo_list_milestones to resolve a milestone name to its id before passing it." to mirror the adjacent labels guideline phrasing. Gates: build (tsc) PASS, check (tsc --noEmit) PASS, test (jest, 179/179) PASS. Lint is not configured anywhere in the repo, so no lint gate ran. No findings remain unresolved.

Critical

(none)

High

(none)

Medium

extensions/forgejo/tests/index.test.ts:94 — No test pins the guideline content added by this change; the registration test only asserts promptGuidelines is a non-empty array, so a future edit could silently drop the milestone cross-reference. Suggested fix: add an assertion (e.g. in tests/index.test.ts) that the promptGuidelines of forgejo_issue_create and forgejo_pr_create each include a reference to forgejo_list_milestones, ideally as a generic invariant over any tool whose parameters schema contains a milestone property.

Low

extensions/forgejo/src/index.ts:358 — Minor wording asymmetry with the adjacent labels guideline ("resolve label names to ids before passing labels" vs "resolve a milestone id before passing it"). Suggested fix (optional polish): mirror the phrasing, e.g. "Use forgejo_list_milestones to resolve a milestone name to its id before passing it."

## 26: Cross-reference forgejo_list_milestones from issue/PR create promptGuidelines Implements [26](https://git.excelera.net/david/pi-extensions-and-skills/issues/26). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 2m 47s. ## Review findings The change is committed and the working tree is clean — the Stage 1 diff is already in place. Let me check the existing test conventions before making fixes.Now I'll apply both fixes: add the guideline-content test (Medium) and mirror the labels wording in the guidelines (Low).Both fixes applied. Now let me run the gates (build, check, test) discovered from `extensions/forgejo/package.json`.All gates pass — 179 tests (up from 178 with the new test). Let me verify the final diff.Both findings are resolved and all gates pass. Here is the final annotated findings document. # Review Findings — 26 ## Summary Both findings were fixed in a single pass. **Medium:** added a generic invariant test in `extensions/forgejo/tests/index.test.ts` asserting that every tool whose `parameters` schema exposes a `milestone` property references `forgejo_list_milestones` in its `promptGuidelines` — pinning the added cross-reference and guarding against future regression. **Low:** reworded the new guideline in both `forgejo_issue_create` and `forgejo_pr_create` to "Use forgejo_list_milestones to resolve a milestone name to its id before passing it." to mirror the adjacent labels guideline phrasing. Gates: build (`tsc`) PASS, check (`tsc --noEmit`) PASS, test (jest, 179/179) PASS. Lint is not configured anywhere in the repo, so no lint gate ran. No findings remain unresolved. ## Critical - (none) ## High - (none) ## Medium - [x] extensions/forgejo/tests/index.test.ts:94 — No test pins the guideline content added by this change; the registration test only asserts `promptGuidelines` is a non-empty array, so a future edit could silently drop the milestone cross-reference. Suggested fix: add an assertion (e.g. in `tests/index.test.ts`) that the `promptGuidelines` of `forgejo_issue_create` and `forgejo_pr_create` each include a reference to `forgejo_list_milestones`, ideally as a generic invariant over any tool whose `parameters` schema contains a `milestone` property. ## Low - [x] extensions/forgejo/src/index.ts:358 — Minor wording asymmetry with the adjacent labels guideline ("resolve label names to ids before passing labels" vs "resolve a milestone id before passing it"). Suggested fix (optional polish): mirror the phrasing, e.g. "Use forgejo_list_milestones to resolve a milestone name to its id before passing it."

david added 2 commits

2026-08-18 08:39:14 +00:00