53: Skip issue creation for chore/documentation commits in commit-changes and commit-docs #56

Merged

david merged 2 commits from feature/issue-53/skip-issue-creation-for-chore-documentation-commit into main

2026-08-19 01:02:27 +00:00

david commented

2026-08-19 01:02:25 +00:00

Owner

53: Skip issue creation for chore/documentation commits in commit-changes and commit-docs

Implements 53.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 11m 28s.

Review findings

Now let's check for any other stale references further in tdd-implementation regarding issue closing / PR body conventions that may need updating too.Good, no other issue-closing references in that file that need updates for the scope of this finding. Now let's fix the README.md commit-docs row (Medium finding).Now the Low finding: hoist label-creation commands in commit-changes/SKILL.md preconditions.Now let's check the "Step 0" reference consistency and run tests.All 31 tests pass, unaffected by the markdown-only changes. Let's verify the final diffs look correct.All three findings addressed. Now producing final annotated findings document.

Review Findings — 53

Summary

Fixed all three findings in a single pass:

High: Updated skills/tdd-implementation/SKILL.md's branch-naming section to reflect the new issue-driven vs. no-issue/date-driven split from AGENTS.md, replacing the stale fully-issue-driven table and prose (including the documentation/issue-3/... and chore/issue-9/... examples).
Medium: Updated the commit-docs row in README.md to describe its actual behavior (no-issue, date-driven commit workflow) instead of the stale, unrelated description.
Low: Hoisted the label-creation commands in skills/commit-changes/SKILL.md into the Preconditions section so both the issue-driven and no-issue/date-driven paths reference the same place, rather than pointing into the "skipped" Step 1.

Re-ran npm test (the only detected gate — node --test scripts/local-install.test.mjs): 31/31 pass, unaffected by these markdown-only changes. No lint or build gates exist in this repo.

Critical

(none)

High

skills/tdd-implementation/SKILL.md:44-50 — This skill still documents the pre-issue-53 convention as "the house convention": the table shows documentation/issue-3/update/issue-9/update-dependencies, and the prose says <type> derives from the issue's label including documentation → documentation/ and chore → chore/, with no mention of the new no-issue/date-driven form. This directly contradicts the updated AGENTS.md and will cause agents following this skill to create issue-numbered branches for chore/documentation work, which is exactly what issue 53 set out to prevent. Suggested fix: update the table/prose to split issue-driven (feature/bug/enhancement) vs. no-issue/date-driven (chore/documentation, <type>/<YYYY-MM-DD>/<slug>) the same way commit-changes/SKILL.md's Branch-Name Guidelines section does, and add a jira-<ticket> fallback note that this only applies when no convention is documented (already partially present).

Medium

README.md:13 — The commit-docs row description ("Write commit messages that keep docs in sync") does not describe what the skill actually does (commits existing docs via a no-issue, date-driven branch → PR → squash-merge workflow, per the skill's own updated description in this diff) and was left unchanged while the adjacent commit-changes row was updated in the same PR to reflect the new issue-driven/no-issue split. Suggested fix: update the commit-docs row to summarize the actual (now-updated) behavior, e.g. "Commit existing docs via a no-issue, date-driven branch → PR → squash-merge workflow (always labeled documentation)."

Low

skills/commit-changes/SKILL.md:42 — The precondition note "(see Step 1 for feature/bug/enhancement — for chore/documentation, create the label the same way, just without an issue attached)" is a little indirect; Step 1 itself is titled "Create the issue (skipped for chore/documentation)" and its label-creation instructions live inside that skipped step, so a reader following only the chore/documentation path has to mentally extract the label-creation sub-steps from a step they're told to skip. Suggested fix: hoist the generic label-creation commands (forgejo_label_create / gh label create / glab label create) into the Preconditions section (or a small shared subsection) so both paths reference the same place without needing to dip into a "skipped" step.

## 53: Skip issue creation for chore/documentation commits in commit-changes and commit-docs Implements [53](https://git.excelera.net/david/pi-extensions-and-skills/issues/53). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 11m 28s. ## Review findings Now let's check for any other stale references further in tdd-implementation regarding issue closing / PR body conventions that may need updating too.Good, no other issue-closing references in that file that need updates for the scope of this finding. Now let's fix the README.md commit-docs row (Medium finding).Now the Low finding: hoist label-creation commands in commit-changes/SKILL.md preconditions.Now let's check the "Step 0" reference consistency and run tests.All 31 tests pass, unaffected by the markdown-only changes. Let's verify the final diffs look correct.All three findings addressed. Now producing final annotated findings document. # Review Findings — 53 ## Summary Fixed all three findings in a single pass: - **High**: Updated `skills/tdd-implementation/SKILL.md`'s branch-naming section to reflect the new issue-driven vs. no-issue/date-driven split from `AGENTS.md`, replacing the stale fully-issue-driven table and prose (including the `documentation/issue-3/...` and `chore/issue-9/...` examples). - **Medium**: Updated the `commit-docs` row in `README.md` to describe its actual behavior (no-issue, date-driven commit workflow) instead of the stale, unrelated description. - **Low**: Hoisted the label-creation commands in `skills/commit-changes/SKILL.md` into the Preconditions section so both the issue-driven and no-issue/date-driven paths reference the same place, rather than pointing into the "skipped" Step 1. Re-ran `npm test` (the only detected gate — `node --test scripts/local-install.test.mjs`): 31/31 pass, unaffected by these markdown-only changes. No lint or build gates exist in this repo. ## Critical (none) ## High - [x] skills/tdd-implementation/SKILL.md:44-50 — This skill still documents the pre-issue-53 convention as "the house convention": the table shows `documentation/issue-3/update/issue-9/update-dependencies`, and the prose says `<type>` derives from the issue's label including `documentation` → `documentation/` and `chore` → `chore/`, with no mention of the new no-issue/date-driven form. This directly contradicts the updated `AGENTS.md` and will cause agents following this skill to create issue-numbered branches for chore/documentation work, which is exactly what issue 53 set out to prevent. Suggested fix: update the table/prose to split issue-driven (`feature`/`bug`/`enhancement`) vs. no-issue/date-driven (`chore`/`documentation`, `<type>/<YYYY-MM-DD>/<slug>`) the same way `commit-changes/SKILL.md`'s Branch-Name Guidelines section does, and add a `jira-<ticket>` fallback note that this only applies when no convention is documented (already partially present). ## Medium - [x] README.md:13 — The `commit-docs` row description ("Write commit messages that keep docs in sync") does not describe what the skill actually does (commits existing docs via a no-issue, date-driven branch → PR → squash-merge workflow, per the skill's own updated description in this diff) and was left unchanged while the adjacent `commit-changes` row was updated in the same PR to reflect the new issue-driven/no-issue split. Suggested fix: update the `commit-docs` row to summarize the actual (now-updated) behavior, e.g. "Commit existing docs via a no-issue, date-driven branch → PR → squash-merge workflow (always labeled `documentation`)." ## Low - [x] skills/commit-changes/SKILL.md:42 — The precondition note "(see Step 1 for `feature`/`bug`/`enhancement` — for `chore`/`documentation`, create the label the same way, just without an issue attached)" is a little indirect; Step 1 itself is titled "Create the issue (skipped for `chore`/`documentation`)" and its label-creation instructions live inside that skipped step, so a reader following only the chore/documentation path has to mentally extract the label-creation sub-steps from a step they're told to skip. Suggested fix: hoist the generic label-creation commands (forgejo_label_create / gh label create / glab label create) into the Preconditions section (or a small shared subsection) so both paths reference the same place without needing to dip into a "skipped" step.

david added 2 commits

2026-08-19 01:02:26 +00:00