issue-92: Validate install:local end-to-end on the dev machine #99

Merged

david merged 3 commits from feature/issue-92/validate-install-local-end-to-end-on-the-dev-machi into main

2026-08-28 02:41:34 +00:00

david commented

2026-08-28 02:41:32 +00:00

Owner

92: Validate install:local end-to-end on the dev machine

Implements 92.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 35m 58s.

Review findings

I have the full picture. Let me verify the README claim about victorialogs before adding the table row:

Confirmed — the README lists victorialogs as a 6th extension while the manifest registers only 5, matching issue #89 observation 3. Now I'll apply the fix for finding #1 (add the missing row to the #92 table):

The edit was applied (the trailing "Negative:" line ensured a unique match against the #92 table rather than the #89 one). Let me verify and run the project's test gate:

Test gate passed 43/43, and the new row is correctly placed in the #92 table (after grillme, matching the ordering of the #89 section). Let me check the final state of the working tree:

Working tree contains exactly one change: the added victorialogs row in the #92 results table. Test gate (43/43) passes; no lint/build scripts exist in this repo.

Decisions on the two remaining findings:

Branch slug truncation — left unresolved: renaming the branch is outside my stage contract (no branch operations), it's systematic pipeline behavior (issue-90 was truncated identically), and codifying a 50-char cap in AGENTS.md is a convention change beyond this docs-only validation issue.
Commit message format — left unresolved: fixing requires amending commit 9daa833 (a git-history operation my stage forbids), and the repo's actual recent practice (issues 74/88/89/90 all use the NN: prefix) conflicts with AGENTS.md's specified format — changing either breaks consistency or is out of scope for this issue.

Review Findings — 92

Summary

Docs-only change: a new "Results — issue #92" section (+27 lines) in docs/IMPLEMENTATION_PLAN.md recording the end-to-end dev-machine validation of npm run install:local. Gates run: test (npm test) → pass (43/43, matching the doc's claim); build/deps (npm install) → pass (up to date, 157 packages audited, 0 vulnerabilities, lockfile unchanged — matching the doc's claim); lint → N/A (no lint script or linter config in the repo). Every independently verifiable claim in the new section was checked against the live machine and the code (origin/main SHA, pi/node/npm versions, package/vulnerability counts, rg match count and line, skill count, settings registration state, all five quoted script messages, dedupe test coverage, cleanup state) and is accurate. No Critical/High/Medium issues; only minor convention/completeness nits below.

Critical

(empty)

High

(empty)

Medium

(empty)

Low

docs/IMPLEMENTATION_PLAN.md:102 — The #92 results table covers all five registered extensions but has no row for victorialogs, which the README advertises as a 6th extension (known manifest mismatch, already noted in issue #89's observation 3); the sibling #89 section at line 137-138 includes an explicit "not applicable" row for it. Suggested fix: add one row to the #92 table, e.g. | Spot-check: victorialogs | ⚠️ not applicable — not registered in the package manifest (see issue #89 observation 3) and no VICTORIALOGS_URL on this machine |, so the end-to-end record is complete for readers cross-referencing the README.
feature/issue-92/validate-install-local-end-to-end-on-the-dev-machi:1 — Branch slug is truncated ("…on-the-dev-machi") instead of the issue title normalized to kebab case per AGENTS.md (validate-install-local-end-to-end-on-the-dev-machine). Suggested fix: rename the branch to the full slug if the pipeline's truncation can be disabled; note this matches prior issue branches (issue-90 was likewise truncated at "…and-relo"), so it is a systematic pipeline behavior — alternatively codify the 50-char slug cap in AGENTS.md.
scripts/local-install.mjs:1 (commit 9daa833) — Commit message 92: Validate install:local end-to-end on the dev machine uses the NN: prefix rather than the issue-<N>: <summary> format AGENTS.md specifies for issue-driven commits. Suggested fix: amend to issue-92: validate install:local end-to-end on the dev machine, or update AGENTS.md to codify the NN: convention the repo has actually used for issues 74/88/89/90 (PR titles already use the issue-<N>: form, so only the commit format is out of step).

Documentation

Updated files:

docs/IMPLEMENTATION_PLAN.md

## 92: Validate install:local end-to-end on the dev machine Implements [92](https://git.excelera.net/david/pi-extensions-and-skills/issues/92). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 35m 58s. ## Review findings I have the full picture. Let me verify the README claim about `victorialogs` before adding the table row: Confirmed — the README lists `victorialogs` as a 6th extension while the manifest registers only 5, matching issue #89 observation 3. Now I'll apply the fix for finding #1 (add the missing row to the #92 table): The edit was applied (the trailing "Negative:" line ensured a unique match against the #92 table rather than the #89 one). Let me verify and run the project's test gate: Test gate passed 43/43, and the new row is correctly placed in the #92 table (after `grillme`, matching the ordering of the #89 section). Let me check the final state of the working tree: Working tree contains exactly one change: the added `victorialogs` row in the #92 results table. Test gate (43/43) passes; no lint/build scripts exist in this repo. Decisions on the two remaining findings: - **Branch slug truncation** — left unresolved: renaming the branch is outside my stage contract (no branch operations), it's systematic pipeline behavior (issue-90 was truncated identically), and codifying a 50-char cap in AGENTS.md is a convention change beyond this docs-only validation issue. - **Commit message format** — left unresolved: fixing requires amending commit `9daa833` (a git-history operation my stage forbids), and the repo's actual recent practice (issues 74/88/89/90 all use the `NN:` prefix) conflicts with AGENTS.md's specified format — changing either breaks consistency or is out of scope for this issue. # Review Findings — 92 ## Summary Docs-only change: a new "Results — issue #92" section (+27 lines) in `docs/IMPLEMENTATION_PLAN.md` recording the end-to-end dev-machine validation of `npm run install:local`. Gates run: **test** (`npm test`) → **pass** (43/43, matching the doc's claim); **build/deps** (`npm install`) → **pass** (up to date, 157 packages audited, 0 vulnerabilities, lockfile unchanged — matching the doc's claim); **lint** → N/A (no lint script or linter config in the repo). Every independently verifiable claim in the new section was checked against the live machine and the code (origin/main SHA, pi/node/npm versions, package/vulnerability counts, rg match count and line, skill count, settings registration state, all five quoted script messages, dedupe test coverage, cleanup state) and is accurate. No Critical/High/Medium issues; only minor convention/completeness nits below. ## Critical (empty) ## High (empty) ## Medium (empty) ## Low - [x] docs/IMPLEMENTATION_PLAN.md:102 — The #92 results table covers all five registered extensions but has no row for `victorialogs`, which the README advertises as a 6th extension (known manifest mismatch, already noted in issue #89's observation 3); the sibling #89 section at line 137-138 includes an explicit "not applicable" row for it. Suggested fix: add one row to the #92 table, e.g. `| Spot-check: victorialogs | ⚠️ not applicable — not registered in the package manifest (see issue #89 observation 3) and no VICTORIALOGS_URL on this machine |`, so the end-to-end record is complete for readers cross-referencing the README. - [ ] feature/issue-92/validate-install-local-end-to-end-on-the-dev-machi:1 — Branch slug is truncated ("…on-the-dev-machi") instead of the issue title normalized to kebab case per AGENTS.md (`validate-install-local-end-to-end-on-the-dev-machine`). Suggested fix: rename the branch to the full slug if the pipeline's truncation can be disabled; note this matches prior issue branches (issue-90 was likewise truncated at "…and-relo"), so it is a systematic pipeline behavior — alternatively codify the 50-char slug cap in AGENTS.md. - [ ] scripts/local-install.mjs:1 (commit `9daa833`) — Commit message `92: Validate install:local end-to-end on the dev machine` uses the `NN:` prefix rather than the `issue-<N>: <summary>` format AGENTS.md specifies for issue-driven commits. Suggested fix: amend to `issue-92: validate install:local end-to-end on the dev machine`, or update AGENTS.md to codify the `NN:` convention the repo has actually used for issues 74/88/89/90 (PR titles already use the `issue-<N>:` form, so only the commit format is out of step). ## Documentation Updated files: - docs/IMPLEMENTATION_PLAN.md

david added 3 commits

2026-08-28 02:41:33 +00:00