Support Claude on Vertex AI (vendor + register vertex-anthropic provider) — B1 #169

david · 2026-08-03T02:53:28Z

david commented

2026-08-03 02:53:28 +00:00

Summary

Adds an opt-in Claude-on-Vertex provider (Option B / Approach B1 from the LLM-provider
investigation). With PILOOP_VERTEX_ANTHROPIC=1 and PILOOP_MODEL="vertex-anthropic/claude-opus-4-8",
pi-loop stage sessions run against Claude models served via Google Cloud Vertex AI using
existing GCP/ADC credentials. Default OFF = zero behavioural change for all existing providers.

Changes

Vendored pi-provider-vertex-anthropic@0.1.3 (MIT) into src/model/vertexAnthropic/
(config, auth, shell, models, messages, vertex-api) with per-file provenance headers.
Added exact dep @earendil-works/pi-ai@0.81.1 (matches the bundled SDK); re-pointed the
vendored @mariozechner/pi-ai imports to it.
registerVertexAnthropic() calls ModelRuntime.registerProvider(...); env-gated
maybeRegisterVertexAnthropic() wired into createPiStageSession.ts.
resolveRegion() also honours GOOGLE_CLOUD_LOCATION (consistency with builtin google-vertex).
Docs: README "Claude on Vertex (optional)", AGENTS.md config note, scope doc marked
B1 implemented, NOTICE for MIT attribution.

Testing

51 new unit tests (config precedence/URLs, auth strategy selection + no token logged,
message/tool conversion, SSE parse + request body, registration gate).
Full suite green: 917 passed.
npm run lint (0 errors/0 warnings) and npm run build pass.
Gated live smoke (PILOOP_E2E=1 + PILOOP_VERTEX_ANTHROPIC=1) — added but not run
here (needs live GCP creds); skips cleanly by default.

Checklist

Self-reviewed the diff
Code follows project conventions (deterministic seams unit-tested; LLM stream as black box)
Descriptive naming
Documentation + MIT attribution updated

Closes #27

## Summary Adds an **opt-in** Claude-on-Vertex provider (Option B / Approach B1 from the LLM-provider investigation). With `PILOOP_VERTEX_ANTHROPIC=1` and `PILOOP_MODEL="vertex-anthropic/claude-opus-4-8"`, pi-loop stage sessions run against Claude models served via Google Cloud Vertex AI using existing GCP/ADC credentials. Default OFF = zero behavioural change for all existing providers. ## Changes - Vendored `pi-provider-vertex-anthropic@0.1.3` (MIT) into `src/model/vertexAnthropic/` (config, auth, shell, models, messages, vertex-api) with per-file provenance headers. - Added exact dep `@earendil-works/pi-ai@0.81.1` (matches the bundled SDK); re-pointed the vendored `@mariozechner/pi-ai` imports to it. - `registerVertexAnthropic()` calls `ModelRuntime.registerProvider(...)`; env-gated `maybeRegisterVertexAnthropic()` wired into `createPiStageSession.ts`. - `resolveRegion()` also honours `GOOGLE_CLOUD_LOCATION` (consistency with builtin google-vertex). - Docs: README "Claude on Vertex (optional)", AGENTS.md config note, scope doc marked B1 implemented, `NOTICE` for MIT attribution. ## Testing - [x] 51 new unit tests (config precedence/URLs, auth strategy selection + **no token logged**, message/tool conversion, SSE parse + request body, registration gate). - [x] Full suite green: **917 passed**. - [x] `npm run lint` (0 errors/0 warnings) and `npm run build` pass. - [ ] Gated live smoke (`PILOOP_E2E=1` + `PILOOP_VERTEX_ANTHROPIC=1`) — added but not run here (needs live GCP creds); skips cleanly by default. ## Checklist - [x] Self-reviewed the diff - [x] Code follows project conventions (deterministic seams unit-tested; LLM stream as black box) - [x] Descriptive naming - [x] Documentation + MIT attribution updated Closes #27

david added 1 commit

2026-08-03 02:53:29 +00:00

Add opt-in Claude-on-Vertex provider (B1, issue-27) 147bb675d7

Vendor pi-provider-vertex-anthropic@0.1.3 (MIT) into src/model/vertexAnthropic/
and register it on the SDK ModelRuntime, gated by PILOOP_VERTEX_ANTHROPIC=1.
Default OFF leaves all existing providers unchanged.

- Add exact dep @earendil-works/pi-ai@0.81.1 (matches bundled SDK).
- Vendor config/auth/shell/models (pure) + messages/vertex-api (imports
  re-pointed to @earendil-works/pi-ai; .js extensions; strict-null guards).
- registerVertexAnthropic + env-gated maybeRegisterVertexAnthropic wired into
  createPiStageSession.
- Unit tests for config, auth (no token logged), messages, SSE/request body,
  and the registration gate; gated e2e smoke (PILOOP_E2E=1 + flag).
- Docs: README 'Claude on Vertex (optional)', AGENTS.md, scope doc marked
  B1 implemented; NOTICE for MIT attribution.

Closes #27

david added 2 commits

2026-08-10 01:31:36 +00:00

Address issue-27 review findings for Vertex-Anthropic provider 0c8ff2aa22

- Add src/model and src/model/vertexAnthropic barrels; import the provider
  registration seam via the module barrel instead of a deep import (High).
- Narrow parseSSE to a local VertexSSEEvent type instead of any (Medium).
- Log message-only diagnostics on each auth strategy's failure path so the
  SA -> ADC -> gcloud fall-through is observable; add tests (Low).
- Document the console.error diagnostics deviation and retained-but-unused
  spawn helper; clarify the enableThinkingBudget model gate (Low/Medium).
- Update NOTICE + per-file provenance headers to match the actual deltas.
- Add model barrel test.

fix merge conflicts with main abf2d97253

david changed title from ~~WIP: Support Claude on Vertex AI (vendor + register vertex-anthropic provider) — B1~~ to Support Claude on Vertex AI (vendor + register vertex-anthropic provider) — B1

2026-08-10 01:32:38 +00:00

david merged commit d0f99f5c30 into main

2026-08-10 01:32:45 +00:00

david deleted branch issue-27/vertex-anthropic-provider

2026-08-10 01:32:45 +00:00

david referenced this pull request from a commit

2026-08-10 01:32:47 +00:00

Support Claude on Vertex AI (vendor + register vertex-anthropic provider) — B1 (#169)

david referenced this pull request

2026-11-06 04:26:49 +00:00

issue-325: Full test sweep for the worktree decision table #331

Sign in to join this conversation.