282: Fix config precedence: piloop-config.yaml should outrank env vars (CLI > YAML > env > defaults) #283

david · 2026-08-19T00:45:28Z

david commented

2026-08-19 00:45:28 +00:00

282: Fix config precedence: piloop-config.yaml should outrank env vars (CLI > YAML > env > defaults)

Implements 282.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 11m 41s.

Review findings

Now let's confirm the change is properly formatted and re-run the gates.There's a format:check script — let's run it plus build/test/lint gates.Good, CHANGELOG.md no longer appears in the warnings list (was 19 files before, now 18 pre-existing ones), confirming the fix. Now run build, test, and lint.Build passed cleanly.All 2030 tests pass.Lint is clean. Final check of the diff status.The fix is minimal, scoped, and the gates all pass. Here's the final annotated findings document.

Review Findings — 282

Summary

Fixed the single Low-severity finding: CHANGELOG.md's wrapped bullet lines under the new "Config precedence" entry violated Prettier's line-wrap indentation for this file. Ran npx prettier --write CHANGELOG.md and confirmed via npx prettier --check CHANGELOG.md (now clean; the file no longer appears in the project-wide format:check warning list, which still shows the same 18 pre-existing unrelated files as before). Re-ran all gates after the fix: npm run build (clean), npm test (142 files / 2030 tests, all green), npm run lint (clean, no eslint issues). No regressions introduced.

Critical

(none)

High

(none)

Medium

(none)

Low

CHANGELOG.md:9-16 — The new "Fixed" entry's wrapped bullet lines are indented with 2 spaces instead of the 2-space-under-list-marker format Prettier expects for this file (confirmed via npx prettier --check CHANGELOG.md, which only flags this newly-added file; it was clean before this diff). Suggested fix: run npx prettier --write CHANGELOG.md (or npm run format) to normalize the new entry's indentation.

## 282: Fix config precedence: piloop-config.yaml should outrank env vars (CLI > YAML > env > defaults) Implements [282](https://git.excelera.net/david/pi-loop/issues/282). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 11m 41s. ## Review findings Now let's confirm the change is properly formatted and re-run the gates.There's a `format:check` script — let's run it plus build/test/lint gates.Good, CHANGELOG.md no longer appears in the warnings list (was 19 files before, now 18 pre-existing ones), confirming the fix. Now run build, test, and lint.Build passed cleanly.All 2030 tests pass.Lint is clean. Final check of the diff status.The fix is minimal, scoped, and the gates all pass. Here's the final annotated findings document. # Review Findings — 282 ## Summary Fixed the single Low-severity finding: `CHANGELOG.md`'s wrapped bullet lines under the new "Config precedence" entry violated Prettier's line-wrap indentation for this file. Ran `npx prettier --write CHANGELOG.md` and confirmed via `npx prettier --check CHANGELOG.md` (now clean; the file no longer appears in the project-wide `format:check` warning list, which still shows the same 18 pre-existing unrelated files as before). Re-ran all gates after the fix: `npm run build` (clean), `npm test` (142 files / 2030 tests, all green), `npm run lint` (clean, no eslint issues). No regressions introduced. ## Critical *(none)* ## High *(none)* ## Medium *(none)* ## Low - [x] CHANGELOG.md:9-16 — The new "Fixed" entry's wrapped bullet lines are indented with 2 spaces instead of the 2-space-under-list-marker format Prettier expects for this file (confirmed via `npx prettier --check CHANGELOG.md`, which only flags this newly-added file; it was clean before this diff). Suggested fix: run `npx prettier --write CHANGELOG.md` (or `npm run format`) to normalize the new entry's indentation.

david added 2 commits

2026-08-19 00:45:29 +00:00

282: Fix config precedence: piloop-config.yaml should outrank env vars (CLI > YAML > env > defaults) ee1658e1a4