284: GitLab auto-merge fails: glab mr merge uses nonexistent --should-remove-source-branch flag #285

david · 2026-08-19T02:04:20Z

david commented

2026-08-19 02:04:20 +00:00

284: GitLab auto-merge fails: glab mr merge uses nonexistent --should-remove-source-branch flag

Implements 284.

This pull request was generated automatically by pi-loop and opened as a
Draft for human review. Do not merge without reviewing the changes.

Generated in 7m 03s.

Review findings

Now let's re-run the gates to confirm everything's still green.Build passes. Now lint and test.All 2033 tests pass, build and lint pass, and format:check is now clean for the touched file. The Low finding is resolved.All gates re-verified green after the fix (build, lint, test, and format:check on the affected file).

Review Findings — 284

Summary

Fixed the single Low-severity finding: reformatted the 'appends captured stderr...' test in src/mr/services/cliMergePollerBase.test.ts with npx prettier --write so it matches Prettier's default style and no longer diverges from the adjacent tests. Re-ran all gates after the fix: npm run build (pass), npm run lint (pass, clean), npm test (pass, 2033/2033), and npx prettier --check on the touched file (now clean). No other findings were raised in this review (all Critical/High/Medium sections were empty).

Critical

(none)

High

(none)

Medium

(none)

Low

src/mr/services/cliMergePollerBase.test.ts:69 — The new 'appends captured stderr...' test's await expect(runner(...)).rejects.toThrow(...) call is not Prettier-formatted (npx prettier --check flags this exact file; all other files touched by the diff are clean). Suggested fix: run npm run format (or npx prettier --write src/mr/services/cliMergePollerBase.test.ts) to collapse the call onto fewer lines per Prettier's default formatting, matching the style of the adjacent omits the stderr suffix... tests in the same file.

## 284: GitLab auto-merge fails: glab mr merge uses nonexistent --should-remove-source-branch flag Implements [284](https://git.excelera.net/david/pi-loop/issues/284). > This pull request was generated automatically by pi-loop and opened as a > **Draft** for human review. Do not merge without reviewing the changes. Generated in 7m 03s. ## Review findings Now let's re-run the gates to confirm everything's still green.Build passes. Now lint and test.All 2033 tests pass, build and lint pass, and format:check is now clean for the touched file. The Low finding is resolved.All gates re-verified green after the fix (build, lint, test, and format:check on the affected file). # Review Findings — 284 ## Summary Fixed the single Low-severity finding: reformatted the `'appends captured stderr...'` test in `src/mr/services/cliMergePollerBase.test.ts` with `npx prettier --write` so it matches Prettier's default style and no longer diverges from the adjacent tests. Re-ran all gates after the fix: `npm run build` (pass), `npm run lint` (pass, clean), `npm test` (pass, 2033/2033), and `npx prettier --check` on the touched file (now clean). No other findings were raised in this review (all Critical/High/Medium sections were empty). ## Critical (none) ## High (none) ## Medium (none) ## Low - [x] src/mr/services/cliMergePollerBase.test.ts:69 — The new `'appends captured stderr...'` test's `await expect(runner(...)).rejects.toThrow(...)` call is not Prettier-formatted (`npx prettier --check` flags this exact file; all other files touched by the diff are clean). Suggested fix: run `npm run format` (or `npx prettier --write src/mr/services/cliMergePollerBase.test.ts`) to collapse the call onto fewer lines per Prettier's default formatting, matching the style of the adjacent `omits the stderr suffix...` tests in the same file.

david added 2 commits

2026-08-19 02:04:20 +00:00

284: GitLab auto-merge fails: glab mr merge uses nonexistent --should-remove-source-branch flag 11b48f34ce