Fold per-stage skill files into bundled prompt modules (#28) #29

david · 2026-07-27T06:45:34Z

david commented

2026-07-27 06:45:34 +00:00

Summary

Fold the per-stage skill bodies into bundled TypeScript modules composed directly into each stage's system prompt, replacing the external *_SKILL_PATH file-loading mechanism and its degrade path.

Closes #28.

What changed

New bundled skill modules under src/skills/: implementSkill.ts, reviewSkill.ts, remediateSkill.ts, mrSkill.ts, plus shared/codeQuality.ts shared by implement + remediate.
composeStagePrompt simplified to wrapper + separator + bundled body; removed the filesystem read, stripFrontmatter, and all degrade branches.
ComposeStagePromptInput now takes body (bundled) instead of skillPath/defaultBody/readSkillFile.
degraded/degradedStages retained in the schema for downstream/artifact compatibility, but always false/[].
Per-stage defaults.ts re-export the bundled bodies under the historic DEFAULT_*_SKILL_BODY names to keep stage wiring stable.
Removed SkillPathsConfig and the skills block from config, loader, and masker.
Retired env vars (now ignored, CLI warns when set): IMPLEMENT_SKILL_PATH, REVIEW_SKILL_PATH, REMEDIATE_SKILL_PATH, MR_SKILL_PATH.
Docs updated: README.md, AGENTS.md.

Testing

npm run lint — passes
npm test — 607 tests pass (77 files)

## Summary Fold the per-stage skill bodies into bundled TypeScript modules composed directly into each stage's system prompt, replacing the external `*_SKILL_PATH` file-loading mechanism and its degrade path. Closes #28. ## What changed - New bundled skill modules under `src/skills/`: `implementSkill.ts`, `reviewSkill.ts`, `remediateSkill.ts`, `mrSkill.ts`, plus `shared/codeQuality.ts` shared by implement + remediate. - `composeStagePrompt` simplified to `wrapper + separator + bundled body`; removed the filesystem read, `stripFrontmatter`, and all degrade branches. - `ComposeStagePromptInput` now takes `body` (bundled) instead of `skillPath`/`defaultBody`/`readSkillFile`. - `degraded`/`degradedStages` retained in the schema for downstream/artifact compatibility, but always `false`/`[]`. - Per-stage `defaults.ts` re-export the bundled bodies under the historic `DEFAULT_*_SKILL_BODY` names to keep stage wiring stable. - Removed `SkillPathsConfig` and the `skills` block from config, loader, and masker. - Retired env vars (now ignored, CLI warns when set): `IMPLEMENT_SKILL_PATH`, `REVIEW_SKILL_PATH`, `REMEDIATE_SKILL_PATH`, `MR_SKILL_PATH`. - Docs updated: `README.md`, `AGENTS.md`. ## Testing - `npm run lint` — passes - `npm test` — 607 tests pass (77 files)

david added 1 commit

2026-07-27 06:45:35 +00:00

Fold per-stage skill files into bundled prompt modules (#28 ) 97c0b964e7

Replace external *_SKILL_PATH file loading with skill bodies bundled as
TypeScript modules under src/skills/, composed directly into each stage
system prompt.

- Add src/skills/{implement,review,remediate,mr}Skill.ts and
  shared/codeQuality.ts (shared by implement + remediate)
- Simplify composeStagePrompt to wrapper + separator + bundled body;
  remove filesystem read, stripFrontmatter, and degrade branches
- ComposeStagePromptInput now takes `body` instead of skillPath/
  defaultBody/readSkillFile
- Retain degraded/degradedStages for schema compatibility (always
  false/[])
- Re-export bundled bodies as DEFAULT_*_SKILL_BODY to keep stage wiring
  stable
- Remove SkillPathsConfig and the skills config block; retire
  IMPLEMENT_SKILL_PATH, REVIEW_SKILL_PATH, REMEDIATE_SKILL_PATH,
  MR_SKILL_PATH (ignored, CLI warns when set)
- Update README.md and AGENTS.md

david merged commit 7d16e95dc5 into main

2026-07-27 06:47:43 +00:00

david deleted branch issue-28/bundle-skill-prompts

2026-07-27 06:47:44 +00:00

david referenced this pull request from a commit

2026-07-27 06:47:45 +00:00

Fold per-stage skill files into bundled prompt modules (#28) (#29)

Sign in to join this conversation.

No reviewers