WIP: issue-300: use Closes keyword in MR description so merges auto-close the issue #301

yousuf · 2026-09-02T23:41:23Z

yousuf commented

2026-09-02 23:41:23 +00:00

What & why

The deterministic MR-description builder opened every MR/PR body with:

Implements [<key>](<url>).

Implements is not a closing keyword on GitLab, GitHub, or Forgejo, so merging a pi-loop MR left the source issue open — operators had to close every issue by hand.

closeIssueAfterAutoMerge (src/orchestrator/services/runPipeline.ts) only fires on the --auto-merge path, so the default Draft-MR flow — the documented human checkpoint — had no issue-closing mechanism at all.

Git-platform issues now get a real closing reference; Jira keeps the descriptive wording because it has no MR-body closing mechanism and its keys are not #-references (Jira is handled by write-back).

Before / after

-Implements [123](https://gitlab.com/acme/widgets/-/issues/123).
+Closes #123 — [123](https://gitlab.com/acme/widgets/-/issues/123).

Jira is unchanged: Implements [ABC-1](…).

Cross-repo issues get the qualified form all three platforms require: Closes acme/tracker#42.

Per-file breakdown

Modified

src/mr/helpers/buildMrDescription.ts — new buildIssueReference() helper picks the wording by provider; new optional mrRepo input on BuildMrDescriptionInput so the builder can tell same-repo from cross-repo and emit the qualified reference only when needed.
src/mr/services/runMrStage.ts — passes originRepo through as mrRepo.
src/mr/helpers/buildMrDescription.test.ts — 7 new cases: closing keyword for each of gitlab/github/forgejo, Jira keeps non-closing wording, issue URL still present, cross-repo qualification, and the two unknown-repo fallbacks.
DESIGN.md — §Stage 4 documents the closing-keyword rule and the Jira exception.

Verification

npm test — 2083 passed / 144 files
npm run lint — clean
npm run build — clean

Remaining tsc --noEmit errors are pre-existing in unrelated test files (gitState.test.ts, authenticatedFetch.test.ts, runStage.test.ts) and untouched here.

Note on scope

This fixes the description text. Worth a separate look: closeIssueAfterAutoMerge remains auto-merge-only, so on platforms/repos where closing keywords are disabled the Draft flow still relies on a human.

Closes #300

## What & why The deterministic MR-description builder opened every MR/PR body with: ``` Implements [<key>](<url>). ``` `Implements` is **not a closing keyword** on GitLab, GitHub, or Forgejo, so merging a pi-loop MR left the source issue open — operators had to close every issue by hand. `closeIssueAfterAutoMerge` (`src/orchestrator/services/runPipeline.ts`) only fires on the `--auto-merge` path, so the default Draft-MR flow — the documented human checkpoint — had no issue-closing mechanism at all. Git-platform issues now get a real closing reference; Jira keeps the descriptive wording because it has no MR-body closing mechanism and its keys are not `#`-references (Jira is handled by write-back). ### Before / after ```diff -Implements [123](https://gitlab.com/acme/widgets/-/issues/123). +Closes #123 — [123](https://gitlab.com/acme/widgets/-/issues/123). ``` Jira is unchanged: `Implements [ABC-1](…)`. Cross-repo issues get the qualified form all three platforms require: `Closes acme/tracker#42`. ## Per-file breakdown **Modified** - `src/mr/helpers/buildMrDescription.ts` — new `buildIssueReference()` helper picks the wording by provider; new optional `mrRepo` input on `BuildMrDescriptionInput` so the builder can tell same-repo from cross-repo and emit the qualified reference only when needed. - `src/mr/services/runMrStage.ts` — passes `originRepo` through as `mrRepo`. - `src/mr/helpers/buildMrDescription.test.ts` — 7 new cases: closing keyword for each of gitlab/github/forgejo, Jira keeps non-closing wording, issue URL still present, cross-repo qualification, and the two unknown-repo fallbacks. - `DESIGN.md` — §Stage 4 documents the closing-keyword rule and the Jira exception. ## Verification - `npm test` — 2083 passed / 144 files - `npm run lint` — clean - `npm run build` — clean Remaining `tsc --noEmit` errors are pre-existing in unrelated test files (`gitState.test.ts`, `authenticatedFetch.test.ts`, `runStage.test.ts`) and untouched here. ## Note on scope This fixes the description text. Worth a separate look: `closeIssueAfterAutoMerge` remains auto-merge-only, so on platforms/repos where closing keywords are disabled the Draft flow still relies on a human. Closes #300

yousuf added 1 commit

2026-09-02 23:41:23 +00:00

issue-300: use Closes keyword in MR description so merges auto-close the issue 132ad75d9a

The MR-description builder opened every body with `Implements [<key>](<url>)`.
`Implements` is not a closing keyword on GitLab, GitHub, or Forgejo, so merging
a pi-loop MR left the source issue open.

Git-platform issues now get `Closes #<number>`, or the cross-repo
`Closes <owner>/<repo>#<number>` form when the issue lives in another
repository. Jira keeps the descriptive `Implements` wording -- it has no
MR-body closing mechanism and its keys are not `#`-references.

yousuf closed this pull request

2026-09-02 23:58:31 +00:00

yousuf commented

2026-09-02 23:58:31 +00:00

Superseded by #302, which uses a real branch (feature/issue-300/mr-description-closes-keyword-auto-close) instead of an AGit refs/pull/ ref. Same commit, same content.

Superseded by #302, which uses a real branch (`feature/issue-300/mr-description-closes-keyword-auto-close`) instead of an AGit `refs/pull/` ref. Same commit, same content.