Surface the posted comment in the run summary and CLI outcome line #307
Labels
No labels
batch
bug
chore
documentation
enhancement
pi-loop
ready
resume
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
david/pi-loop#307
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Make the operator's run summary and the CLI
Outcome:line reflect that the issue was commented on (with an "already commented" variant on resume), so a no-code-change run's end state is legible from both surfaces (ADR-021 §8). Batch mode/manifest behavior is intentionally unchanged.Background
Depends on: #306
Today a no-code-change run ends with an outcome line saying no code change was produced, but nothing tells the operator the issue was commented on. This step updates two surfaces:
buildNoCodeChangeSummaryinsrc/orchestrator/services/runPipeline.ts(the summary builder, ~line 234).'noCodeChange' in resultoutcome writer insrc/cli/services/runCli.ts(~line 1271).Batch/manifest must not change: a no-code-change issue already counts as completed and the comment is unconditional — leave
runBatch/batchManifestalone and add an explanatory comment in the diff stating why.Implementation Details
runPipeline.ts— extendbuildNoCodeChangeSummarywith an optionalnoCodeChangeCommentparameter; when the post happened this run, add a line such asCommented on the issue explaining why no code changes are needed. When the marker pre-existed (resume), render the same line or an(already commented)variant — pick one behavior and test it.runCli.ts— in the no-code-change outcome writer, append— commented on issue(driven by the run-pipeline result field from the wiring step) to theOutcome: no-code-change …line; omit it when the field is absent.src/batch/services/runBatch.ts/batchManifest.ts— no code change; add a short comment in the diff explaining why.Acceptance Criteria
— commented on issuewhen the result carries the comment marker and omits it when not.src/orchestrator/services/runPipeline.test.tsandsrc/cli/services/runCli.test.ts.Test Plan
npm testandnpm run lint.pi-loop opened and merged a pull request for this issue: #317