Surface the posted comment in the run summary and CLI outcome line #307

Closed
opened 2026-09-05 18:35:41 +00:00 by david · 1 comment
Owner

Summary

Make the operator's run summary and the CLI Outcome: line reflect that the issue was commented on (with an "already commented" variant on resume), so a no-code-change run's end state is legible from both surfaces (ADR-021 §8). Batch mode/manifest behavior is intentionally unchanged.

Background

Depends on: #306

Today a no-code-change run ends with an outcome line saying no code change was produced, but nothing tells the operator the issue was commented on. This step updates two surfaces:

  1. buildNoCodeChangeSummary in src/orchestrator/services/runPipeline.ts (the summary builder, ~line 234).
  2. The 'noCodeChange' in result outcome writer in src/cli/services/runCli.ts (~line 1271).

Batch/manifest must not change: a no-code-change issue already counts as completed and the comment is unconditional — leave runBatch/batchManifest alone and add an explanatory comment in the diff stating why.

Implementation Details

  • runPipeline.ts — extend buildNoCodeChangeSummary with an optional noCodeChangeComment parameter; when the post happened this run, add a line such as Commented on the issue explaining why no code changes are needed. When the marker pre-existed (resume), render the same line or an (already commented) variant — pick one behavior and test it.
  • runCli.ts — in the no-code-change outcome writer, append — commented on issue (driven by the run-pipeline result field from the wiring step) to the Outcome: no-code-change … line; omit it when the field is absent.
  • src/batch/services/runBatch.ts / batchManifest.ts — no code change; add a short comment in the diff explaining why.
  • Keep all output text deterministic.

Acceptance Criteria

  • Run summary contains the comment line when the comment was posted this run, and the chosen variant when the marker pre-existed (resume).
  • CLI outcome line includes — commented on issue when the result carries the comment marker and omits it when not.
  • Existing batch and CLI no-code-change count tests pass unchanged (no behavior change to batch/manifest).
  • Summary + CLI changes covered in src/orchestrator/services/runPipeline.test.ts and src/cli/services/runCli.test.ts.

Test Plan

  • Unit tests per above; then npm test and npm run lint.
## Summary Make the operator's run summary and the CLI `Outcome:` line reflect that the issue was commented on (with an "already commented" variant on resume), so a no-code-change run's end state is legible from both surfaces (ADR-021 §8). Batch mode/manifest behavior is intentionally unchanged. ## Background **Depends on:** #306 Today a no-code-change run ends with an outcome line saying no code change was produced, but nothing tells the operator the issue was commented on. This step updates two surfaces: 1. `buildNoCodeChangeSummary` in `src/orchestrator/services/runPipeline.ts` (the summary builder, ~line 234). 2. The `'noCodeChange' in result` outcome writer in `src/cli/services/runCli.ts` (~line 1271). Batch/manifest must **not** change: a no-code-change issue already counts as completed and the comment is unconditional — leave `runBatch`/`batchManifest` alone and add an explanatory comment in the diff stating why. ## Implementation Details - `runPipeline.ts` — extend `buildNoCodeChangeSummary` with an optional `noCodeChangeComment` parameter; when the post happened this run, add a line such as `Commented on the issue explaining why no code changes are needed`. When the marker pre-existed (resume), render the same line or an `(already commented)` variant — pick one behavior and test it. - `runCli.ts` — in the no-code-change outcome writer, append `— commented on issue` (driven by the run-pipeline result field from the wiring step) to the `Outcome: no-code-change …` line; omit it when the field is absent. - `src/batch/services/runBatch.ts` / `batchManifest.ts` — no code change; add a short comment in the diff explaining why. - Keep all output text deterministic. ## Acceptance Criteria - [ ] Run summary contains the comment line when the comment was posted this run, and the chosen variant when the marker pre-existed (resume). - [ ] CLI outcome line includes `— commented on issue` when the result carries the comment marker and omits it when not. - [ ] Existing batch and CLI no-code-change count tests pass unchanged (no behavior change to batch/manifest). - [ ] Summary + CLI changes covered in `src/orchestrator/services/runPipeline.test.ts` and `src/cli/services/runCli.test.ts`. ## Test Plan - Unit tests per above; then `npm test` and `npm run lint`.
david closed this issue 2026-09-05 19:57:26 +00:00
Author
Owner

pi-loop opened and merged a pull request for this issue: #317

pi-loop opened and merged a pull request for this issue: https://git.excelera.net/david/pi-loop/pulls/317
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
david/pi-loop#307
No description provided.