Consolidated unit-test seams for the no-code-change comment feature #309

New issue

david · 2026-09-05T18:36:05Z

david commented

2026-09-05 18:36:05 +00:00

Summary

Close out per-step unit coverage with a consolidated seam→test-file matrix, ensuring every deterministic surface of the no-code-change comment feature is tested and the whole unit suite plus lint is green together (ADR-021 §9).

Background

Depends on: #303, #304, #305, #306, #307, #308

Each implementation step shipped its own tests. This step is the completeness audit + green run: verify each seam has its test file with the listed coverage, fix any gaps, and run the full suite once. No production behavior changes here — production code is only touched if a test exposes a genuine defect in one of the new seams.

Implementation Details

Confirm/complete this matrix (create or extend the test files, then run everything):

Seam	Test file
`buildNoCodeChangeCommentBody`	`src/writeback/helpers/buildNoCodeChangeCommentBody.test.ts`
`validateNoCodeChangeCommentArtifact`	`src/artifacts/helpers/validateNoCodeChangeComment.test.ts`
marker write/read service	`src/artifacts/services/noCodeChangeCommentArtifact.test.ts`
`postNoCodeChangeComment` (posted / marker-skip / throw)	`src/writeback/services/postNoCodeChangeComment.test.ts`
short-circuit wiring incl. fatal path + result field	`src/orchestrator/services/runPipeline.test.ts`
summary + CLI text	`runPipeline.test.ts` + `src/cli/services/runCli.test.ts`
resume mapping (`isImplementStageComplete`)	`src/run/services/determineResumeStage.test.ts`

Acceptance Criteria

Every row of the matrix has a test file present in the repo with the stated coverage — no seam without a test.
npm test passes with the new suites included.
npm run lint is clean.
No production code changed unless a test exposed a genuine defect — if so, fix the seam and note it in the PR/issue.

Test Plan

npm test; npm run lint. Everything green = done.

## Summary Close out per-step unit coverage with a consolidated seam→test-file matrix, ensuring every deterministic surface of the no-code-change comment feature is tested and the whole unit suite plus lint is green together (ADR-021 §9). ## Background **Depends on:** #303, #304, #305, #306, #307, #308 Each implementation step shipped its own tests. This step is the completeness audit + green run: verify each seam has its test file with the listed coverage, fix any gaps, and run the full suite once. No production behavior changes here — production code is only touched if a test exposes a genuine defect in one of the new seams. ## Implementation Details Confirm/complete this matrix (create or extend the test files, then run everything): | Seam | Test file | | --- | --- | | `buildNoCodeChangeCommentBody` | `src/writeback/helpers/buildNoCodeChangeCommentBody.test.ts` | | `validateNoCodeChangeCommentArtifact` | `src/artifacts/helpers/validateNoCodeChangeComment.test.ts` | | marker write/read service | `src/artifacts/services/noCodeChangeCommentArtifact.test.ts` | | `postNoCodeChangeComment` (posted / marker-skip / throw) | `src/writeback/services/postNoCodeChangeComment.test.ts` | | short-circuit wiring incl. fatal path + result field | `src/orchestrator/services/runPipeline.test.ts` | | summary + CLI text | `runPipeline.test.ts` + `src/cli/services/runCli.test.ts` | | resume mapping (`isImplementStageComplete`) | `src/run/services/determineResumeStage.test.ts` | ## Acceptance Criteria - [ ] Every row of the matrix has a test file present in the repo with the stated coverage — no seam without a test. - [ ] `npm test` passes with the new suites included. - [ ] `npm run lint` is clean. - [ ] No production code changed unless a test exposed a genuine defect — if so, fix the seam and note it in the PR/issue. ## Test Plan - `npm test`; `npm run lint`. Everything green = done.

david added this to the No-code-change comment: verification & docs milestone

2026-09-05 18:36:05 +00:00

david added the

chore

ready

labels

2026-09-05 18:36:05 +00:00

Sign in to join this conversation.